Update generate_datasets.R #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix generate_datasets.R so that it doesn't crash when "complexity_1", ..., "complexity_5" directories are not already created in the current directory. Also export the covariate information alongside the other outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor pull request related to the supplied "datasets" directory in the package and their generation.
Running "generate_datasets.R" currently crashes when the "complexity_1", ..., "complexity_5" directories are not already created in the current directory, so the first edit creates these directories if they don't already exist.
The final edit is to make export the covariate data into csv files alongside the other outputs.
I would rerun the code and then add the generated covariate data in this pull request, except the "generate_datasets.R" does not create consistent outputs between different computers.
I ran this script on Windows, Linux, and Mac (both x86 and arm), and sometimes the generated datasets are the same, but most of the time they are significantly different.
So if you agree with these changes, can I please ask that you also add the generated covariates data to the datasets/complexity_* folders in another commit?
Thanks very much! Patrick