forked from MarathonLabs/marathon
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract code coverage from Android device #21
Open
karthyks
wants to merge
23
commits into
feature/agoda-android-ci
Choose a base branch
from
android-code-coverage
base: feature/agoda-android-ci
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthyks
commented
Sep 26, 2023
core/src/main/kotlin/com/malinskiy/marathon/analytics/tracker/TrackerFactory.kt
Outdated
Show resolved
Hide resolved
karthyks
commented
Sep 26, 2023
core/src/main/kotlin/com/malinskiy/marathon/report/internal/TestCoverageReporter.kt
Outdated
Show resolved
Hide resolved
karthyks
commented
Sep 27, 2023
Comment on lines
+19
to
+36
val point = Point.measurement("tests") | ||
.time(System.currentTimeMillis(), TimeUnit.MILLISECONDS) | ||
.tag("testname", testResult.test.toSafeTestName()) | ||
.tag("package", testResult.test.pkg) | ||
.tag("class", testResult.test.clazz) | ||
.tag("method", testResult.test.method) | ||
.tag("deviceSerial", device.serialNumber) | ||
.addField("ignored", if (testResult.isIgnored) 1.0 else 0.0) | ||
.addField("success", if (testResult.status == TestStatus.PASSED) 1.0 else 0.0) | ||
.addField("duration", testResult.durationMillis()) | ||
.build() | ||
runCatching { | ||
influxDb.write(point) | ||
}.onSuccess { | ||
logger.trace { "Tracked in influxDB $point" } | ||
}.onFailure { | ||
logger.error(it) { "Error writing to influxDB with $point" } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are having an issue writing to influxDB 400 Bad Request, just want to log the request marathon is sending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage report is generated in the folder /data/data/$appPackage/files/coverage.ec
TestFinished -> Get coverage.ec file from the device -> Copy the file contents to the output directory with file name (testClass#testMethod.ec)