Remove dependency to reach-ui
#1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 41cddca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
nathsimpson
reviewed
Mar 8, 2023
|
|
||
| // Workaround for https://github.com/webpack/webpack/issues/14814 | ||
| // https://github.com/eps1lon/material-ui/blob/8d5f135b4d7a58253a99ab56dce4ac8de61f5dc1/packages/mui-utils/src/useId.ts#L21 | ||
| const maybeReactUseId: undefined | (() => string) = (React as any)[ |
There was a problem hiding this comment.
We have an any warning here. Is that going to annoy us going forward?
There was a problem hiding this comment.
That's a good point, I've just added an eslint-disable-next-line @typescript-eslint/no-explicit-any above this line
nathsimpson
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We use
@reach/auto-idto autogenerate IDs to facilitate WAI-ARIA and server rendering. We can not just useuseIdfrom React as we need to provide support for React 16, 17 and 18.Reach UI is no longer being maintained and does not fully support React 18. See reach/reach-ui#972 for more details.
In this PR, I have removed the dependency to Reach UI and the logic from
@reach/auto-idhas been forked and copied into the repo.