-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drawer: allow a custom element to be focused on close #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d65f498 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
stowball
reviewed
May 6, 2024
stowball
reviewed
May 6, 2024
stowball
reviewed
May 6, 2024
stowball
reviewed
May 6, 2024
stowball
reviewed
May 6, 2024
Co-authored-by: Matt Stow <[email protected]>
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
24f8f20
to
6994c07
Compare
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
stowball
reviewed
May 9, 2024
Co-authored-by: Matt Stow <[email protected]>
Co-authored-by: Matt Stow <[email protected]>
Co-authored-by: Matt Stow <[email protected]>
stowball
reviewed
May 9, 2024
ChrisLaneAU
commented
May 10, 2024
|
stowball
approved these changes
May 10, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the
Drawer
to return focus to a custom element while maintaining the fallback of the existing trigger element. It also establishes afocusAll
prop (naming was derived from the similarly behavingfocus
prop) on theBox
component that is used by the two alert components.The combination of these changes allows consumers to return focus to an alert, for example when a file upload in a drawer throws an error and we render the error style alert.
View preview
Checklist
Preflight
accordion: Updated padding
ordocs: Updated header links
yarn changeset
. Learn more about change management.Testing
yarn test
to ensure tests are passing. If required, runyarn test -u
to update any generated snapshots.Documentation