Audit 2024 feature branch #1726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f70968 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
* Audit: nested side nav examples * not needed
audit: Add SiteLayout to variou stories
* Bypass sign-in, don't save form state & remove Simpsons * Add help reference details -> drawer * Side page progress L2 with related changes * Add time inputs * Fix invalid * Fix copy * File upload example * app-layout-sidebar l2 * Fix owner details layout and names * Small date field --------- Co-authored-by: Chris Lane <[email protected]>
Fix table dropdown size and storybook HMR
* table-settings * Button panel updates * Keep business name visible at all times * Always true * Close button should not update state * Handle undefined dates in active filters * Apply activeColumns prop * Table settings aria * Actions as capital * Design QA * Fix appliedSettingsCount * Fix table settings properly * lint * checkboxes aren't required --------- Co-authored-by: Matt Stow <[email protected]>
* table: fixed columns * Tests * Changeset * Typo * Remove TODO * Add missing TableWrapper * Fixes * Fix safari overscroll, enable scroll overlays on small screens, add extra stories for single frozen columns * Snaps * Resize observer * Grab to scroll * No grab, fix vertical scroll * Audit: Temporary audit redirects (#1722) * update snapshots * slightly better selection * pxToRem. 1 ratio by default * different method of highlighting selected rows * Fix load perf * Fix zindex issue with dropdowms in frozen columns * Fix table header borders appearing over sticky columns * Correct shadow & border handling (minus transitions) * Fix fractional scroll positions * Fix fractional scroll positions properly * Hackily fix scroll offsets on column change * Force scroll at max size. Fix shadows on small screens. Fix reset settings button --------- Co-authored-by: Chris Lane <[email protected]>
|
Make storybook dropdown actions have unique description
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an overview of your changes here. Include screenshots, photos or links if necessary.
View preview
Checklist
Preflight
accordion: Updated paddingordocs: Updated header linksyarn changeset. Learn more about change management.Testing
yarn testto ensure tests are passing. If required, runyarn test -uto update any generated snapshots.Documentation
Creating new component
docs/overview.mdxanddocs/code.mdxat a minimum)yarnin the root of the repo to do this)docs/components/designSystemComponents.tsx).storybook/stories/KitchenSink.tsx)docs/playroom/snippets.ts)docs/components/pictograms/index.tsx)