audit updates to Content-principles and links added #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7e0529 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
stowball
reviewed
Oct 3, 2024
|
|
||
| If content already appears on the Export Service or the [Department of Agriculture, Fisheries and Forestry](https://www.agriculture.gov.au/) (DAFF) website, link to the authoritative source. | ||
| If content already appears somewhere online link to the authoritative source. For example, the [Export Service](https://exports.agriculture.gov.au/). Or the [Department of Agriculture, Fisheries and Forestry](https://www.agriculture.gov.au/) (DAFF) website. |
There was a problem hiding this comment.
Feels weird starting this sentence with "or", shouldn't it just be a continuation? For example, the Export Service of the DAFF website
stowball
reviewed
Oct 3, 2024
| @@ -7,7 +7,7 @@ order: 1 | |||
|
|
|||
| You can use these standards to guide you to create content that is clear and effective. | |||
|
|
|||
| Good content reduces the cognitive load on users and helps them achieve their aims more easily. | |||
| Good content reduces the cognitive load on users. It helps them achieve their aims more easily. | |||
There was a problem hiding this comment.
Weirdly, having a new sentence for "It" seems to increase cognitive load for me 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an overview of your changes here. Include screenshots, photos or links if necessary.
View preview
Checklist
Preflight
accordion: Updated paddingordocs: Updated header linksyarn changeset. Learn more about change management.Testing
yarn testto ensure tests are passing. If required, runyarn test -uto update any generated snapshots.Documentation
Creating new component
docs/overview.mdxanddocs/code.mdxat a minimum)yarnin the root of the repo to do this)docs/components/designSystemComponents.tsx).storybook/stories/KitchenSink.tsx)docs/playroom/snippets.ts)docs/components/pictograms/index.tsx)