Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicating dependencies isn't something I got around to while I was working on AgDS, but it's something I thought this project could benefit from. A duplicate dependency is when two dependencies are resolved to different versions, even when a single version matches the range specified in the dependencies.
Since AgDS is on Yarn v1, I used the yarn-deduplicate package to find and deduplicate dependencies. Deduplicating is a native feature of Yarn 2+, so if this project upgrades this dependency can be removed.
These changes will have no impact on AgDS consumers, since the
yarn.lock
is never published to NPM. The main benefits of this pull request is faster yarn installs. To do a quick comparison, the yarn install step on a recent branch build took 15 seconds. The same step on this branch ran in 7seconds.Upgrading @babel/*
Initially for this pull request I just ran
yarn yarn-deduplicate
and all tests/builds were fine except forplayroom
which failed when building. In order to fix this error, I just had to bump a few@babel/*
dependencies.CI Check
As part of this PR, I've added a new script
yarn lint:duplicates
which will ensure no duplicates exist in theyarn.lock
file. Since theyarn lint
script, which runs in CI, will run all scripts that are prefixed withlint:
in CI, no changes are required in order to get this check running in CI.Link to CI check for this branch.
Verbose logs when running
yarn yarn-deduplicate --list
Below are all of the dependencies that have been deduplicated as part of this pull request.
View verbose logs