TaskList: task list to support notRequired status
#1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a663171 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stowball
reviewed
Nov 18, 2024
stowball
reviewed
Nov 18, 2024
stowball
reviewed
Nov 18, 2024
stowball
reviewed
Nov 18, 2024
stowball
reviewed
Nov 18, 2024
| @@ -94,6 +97,8 @@ const TaskListItem = ({ | |||
| css={{ | |||
| position: 'relative', | |||
| textDecoration: 'none', | |||
| cursor: isDisabled ? 'not-allowed' : 'pointer', | |||
There was a problem hiding this comment.
FYI the design team will do a review of this and follow up with you
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an overview of your changes here. Include screenshots, photos or links if necessary.
Following changes are implemented:
messagecan be string or aReactNodenotRequiredadded. It makes that step skippable. In some business cases, a step becomenot requiredbecause of some business conditions. This caters to such needs.View preview
Checklist
Preflight
accordion: Updated paddingordocs: Updated header linksyarn changeset. Learn more about change management.Testing
yarn testto ensure tests are passing. If required, runyarn test -uto update any generated snapshots.Documentation
Creating new component
docs/overview.mdxanddocs/code.mdxat a minimum)yarnin the root of the repo to do this)docs/components/designSystemComponents.tsx).storybook/stories/KitchenSink.tsx)docs/playroom/snippets.ts)docs/components/pictograms/index.tsx)