Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start deprecating old stuff #143

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Start deprecating old stuff #143

merged 7 commits into from
Mar 25, 2024

Conversation

alvarolopez
Copy link
Collaborator

No description provided.

@alvarolopez alvarolopez force-pushed the deprecations branch 2 times, most recently from e833458 to dabd92a Compare March 15, 2024 12:19
@alvarolopez
fix: remove warnings in test model
dc88b70
@alvarolopez
fix: remove marshmallow deprecation warnings
1c505f3
@alvarolopez
feat: add deprecation warnings for test module
9b396cb 
This is the initial step for #132
@alvarolopez
feat: add deprecation warnings when loading several models
440de68 
This is required for #130, #128

Fixesd #129
@alvarolopez
feat: add option to allow to load a single module
6728b33 
Since we are deprecating loading several models (#128, #129, #132) we
need to ensure that users are able to load only a single module, even if
several are present.
@alvarolopez alvarolopez force-pushed the deprecations branch 3 times, most recently from d80d248 to 6728b33 Compare March 19, 2024 10:33
IgnacioHeredia
IgnacioHeredia approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@IgnacioHeredia IgnacioHeredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alvarolopez alvarolopez merged commit 2ae84d2 into master Mar 25, 2024
10 checks passed
@alvarolopez alvarolopez deleted the deprecations branch March 25, 2024 12:45
@vykozlov
Copy link
Contributor

vykozlov commented Mar 25, 2024 •
edited
Loading

A comment: for 2.3.1 we should re-create demo_app in the ai4os-hub repo and move away from deephdc (message in deepaas/model/v2/__init__.py )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioHeredia IgnacioHeredia IgnacioHeredia approved these changes

@vykozlov vykozlov Awaiting requested review from vykozlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarolopez @vykozlov @IgnacioHeredia