Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #536

Closed
zware opened this issue Apr 1, 2021 · 12 comments · Fixed by #619
Closed

New release? #536

zware opened this issue Apr 1, 2021 · 12 comments · Fixed by #619

Comments

@zware
Copy link

zware commented Apr 1, 2021

There are a few useful changes that are not available in the latest 0.11.1 release, such as #478 (fixing Redis clear with namespace that happens to be empty), #470 (quieter imports), #514 (explicit support for Python 3.9).

I couldn't find documentation of release plans, so I figured I would just ask here :)

Thanks!

@amatai
Copy link

amatai commented Jul 10, 2021

Also interested to know about this plan. We are having to fork and use our own master branch for the redis clear fix.
Will be very helpful to have a new release.
Willing to help in this effort.

@Dreamsorcerer
Copy link
Member

I don't have time to revive the project right now, but I can review and merge PRs if someone wants to get started.

First task will be to get the CI running again, replacing Travis with Github. Use the configuration from one of our other repos as a reference, e.g.: https://github.com/aio-libs/aiohttp-jinja2/blob/master/.github/workflows/ci.yml

@Mark90
Copy link
Contributor

Mark90 commented Mar 6, 2022

@Dreamsorcerer Should the Github CI build upon the tox/Makefile setup, or doesn't matter how it does the job as long as it lints tests and deploys?

@Dreamsorcerer
Copy link
Member

Doesn't need tox, just use a version matrix like in the other projects.

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Mar 15, 2022

OK, CI is running again (thanks @Mark90).

A few more tasks I'd like to take a look at before making a new release (updating aioredis is the main one, and should definetely happen before release):

  • Update aioredis ([Bugfix] Add redis-py >= 4.2.0 support #546 needs updating)
  • Resolve remaining test failures/warnings (Some tests are being skipped at the moment, and warnings are being ignored, probably needs aioredis updating first) (Fix warnings, use autospec etc. #588)
  • Remove old/deprecated mentions of loop
  • Add Python 3.10
  • Add Python 3.11
  • Mypy (Start by uncommenting check_untyped_defs in .mypy.ini and fixing the errors that appear)
  • Replace MagicMock etc. with create_autospec() (Fix warnings, use autospec etc. #588)
  • Maybe use aiojobs for background tasks (We have unmanaged tasks in a couple of places created with asyncio.create_task(), which is bad practice)
  • Replace pytest.KEY (It's a stop-gap measure for a long-deprecated feature).
  • Setup Dependabot with auto-merge like our other repos (e.g. look at aiohttp-jinja2).

If anyone wants to pick up some of these tasks, that would be great.

@citramon citramon mentioned this issue May 12, 2022
4 tasks
@citramon
Copy link
Contributor

@Dreamsorcerer, could you check 572? It's for the last checkbox :)

@nikolaevigor
Copy link

so is this project dead?

@Dreamsorcerer
Copy link
Member

Tests are running again, except for #585. If anyone has time to debug that one, that would be great. I'll continue on with the other tasks on the list for now, and start looking at all the open PRs.

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Jan 1, 2023

OK, I think as we sort out typing, aiojobs and other open issues, it looks like there will need to be some significant changes to the design.

So, I'll push a release as soon as we have Python 3.11 sorted. The tests on 3.11 are failing, seemingly with the caches not retrieving values: #618.

@Dreamsorcerer
Copy link
Member

Right, looks like we've got 3.11 working (thanks @a68366). I'll look at doing a release on Friday.

If there's any more PRs people want merged, now is the time. There are quite a few reasonable looking PRs that people haven't bothered to add tests to. So, if anyone wants to finish up any of those, that'd be great.

@Dreamsorcerer
Copy link
Member

OK, finally out.

If anyone wants to contribute to the next major release, I've tagged several things to do under the 1.0 milestone which are likely to result in backwards-incompatible changes.
https://github.com/aio-libs/aiocache/milestone/8

@padraic-shafer
Copy link
Contributor

@Dreamsorcerer Thank you for driving all these updates and getting them released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants