Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test keys refactoring #572

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

citramon
Copy link
Contributor

What do these changes do?

Preparing for new release.
Test keys refactoring.

Are there changes in behavior for the user?

Related issue number

Resolvers: 536

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@citramon citramon mentioned this pull request May 12, 2022
@Dreamsorcerer
Copy link
Member

Looks reasonable to me. Thanks.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #572 (fd03ae8) into master (02782c2) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   98.13%   98.17%   +0.04%     
==========================================
  Files          13       13              
  Lines        1017     1040      +23     
  Branches      140      140              
==========================================
+ Hits          998     1021      +23     
  Misses         15       15              
  Partials        4        4              
Flag Coverage Δ
unit 98.17% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiocache/base.py 100.00% <0.00%> (ø)
aiocache/factory.py 100.00% <0.00%> (ø)
aiocache/plugins.py 100.00% <0.00%> (ø)
aiocache/decorators.py 100.00% <0.00%> (ø)
aiocache/backends/memory.py 100.00% <0.00%> (ø)
aiocache/backends/memcached.py 100.00% <0.00%> (ø)
aiocache/backends/redis.py 93.46% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02782c2...fd03ae8. Read the comment docs.

@Dreamsorcerer Dreamsorcerer merged commit 760ccab into aio-libs:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants