Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise correct error message when create cache proxy with absent cache type #794

Closed
wants to merge 1 commit into from

Conversation

ar0ne
Copy link

@ar0ne ar0ne commented Dec 22, 2023

What do these changes do?

I got this error message when tried to use aiocache with redis.

assert issubclass(cache_class, BaseCache)
TypeError: issubclass() arg 1 must be a class

Basically, I wasn't sure which dependency is missed, because I assumed pip install aiocache should install all required. Also this command from readme doesn't work for me.

>> pip install aiocache[redis]
zsh: no matches found: aiocache[redis]

Are there changes in behavior for the user?

Related issue number

Fixes #539

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Dreamsorcerer
Copy link
Member

zsh: no matches found: aiocache[redis]
Looks like a shell error, maybe try 'aiocache[redis]'? I assume your shell is trying to do something with the brackets.

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Dec 22, 2023

I'm planning to remove the whole factory thing from v1, which will avoid silly errors like this completely. If you can retarget the PR to the 0.12 branch though, I'll merge this in for now.

@ar0ne ar0ne changed the base branch from master to 0.12 December 22, 2023 17:10
@ar0ne ar0ne changed the base branch from 0.12 to master December 22, 2023 17:12
@ar0ne
Copy link
Author

ar0ne commented Dec 22, 2023

recreated #795

@ar0ne ar0ne closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants