Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #924

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Drop Python 3.8 support #924

merged 5 commits into from
Nov 19, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 19, 2024

Drop Python 3.8 support as it has reached EOL and all the deps no longer support it causing all the dependabot PRs to fail which means we have no visibility if the CI is working or upstream changes are causing incompatibilities.

CHANGES/924.removal Outdated Show resolved Hide resolved
@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2024

@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2024

good

Successfully installed MarkupSafe-2.1.5 aiodocker-0.1.dev1+g06cc2a1 aiohappyeyeballs-2.4.3 aiohttp-3.10.5 aiosignal-1.3.1 async-timeout-4.0.3 attrs-24.2.0 cattrs-24.1.2 certifi-2024.8.30 cfgv-3.4.0 charset-normalizer-3.3.2 click-8.1.7 codecov-2.1.13 coverage-7.6.1 distlib-0.3.8 exceptiongroup-1.2.2 filelock-3.16.1 frozenlist-1.4.1 identify-2.6.1 idna-3.10 iniconfig-2.0.0 jinja2-3.1.4 lsprotocol-2023.0.1 multidict-6.0.5 mypy-1.11.2 mypy-extensions-1.0.0 nodeenv-1.9.1 packaging-24.1 platformdirs-4.3.6 pluggy-1.5.0 pre-commit-4.0.0 pygls-1.3.1 pytest-8.3.2 pytest-asyncio-0.24.0 pytest-cov-5.0.0 pytest-sugar-1.0.0 pyyaml-6.0.2 requests-2.32.3 ruff-0.6.3 ruff-lsp-0.0.54 termcolor-2.5.0 tomli-2.0.2 towncrier-24.8.0 typing-extensions-4.12.2 urllib3-2.2.3 virtualenv-20.26.6 yarl-1.11.1

broken

Successfully installed MarkupSafe-3.0.0 aiodocker-0.1.dev1+g06cc2a1 aiohappyeyeballs-2.4.3 aiohttp-3.10.5 aiosignal-1.3.1 async-timeout-4.0.3 attrs-24.2.0 cattrs-24.1.2 certifi-2024.8.30 cfgv-3.4.0 charset-normalizer-3.3.2 click-8.1.7 codecov-2.1.13 coverage-7.6.1 distlib-0.3.8 filelock-3.16.1 frozenlist-1.4.1 identify-2.6.1 idna-3.10 iniconfig-2.0.0 jinja2-3.1.4 lsprotocol-2023.0.1 multidict-6.0.5 mypy-1.11.2 mypy-extensions-1.0.0 nodeenv-1.9.1 packaging-24.1 platformdirs-4.3.6 pluggy-1.5.0 pre-commit-4.0.0 pygls-1.3.1 pytest-8.3.2 pytest-asyncio-0.24.0 pytest-cov-5.0.0 pytest-sugar-1.0.0 pyyaml-6.0.2 requests-2.32.3 ruff-0.6.3 ruff-lsp-0.0.54 termcolor-2.5.0 towncrier-24.8.0 typing-extensions-4.12.2 urllib3-2.2.3 virtualenv-20.26.6 yarl-1.11.1

@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2024

I don't see anything obvious that explains the failure

@asvetlov
Copy link
Member

Thanks for taking care!
I suggest blindly updating library versions first and drop py-3.8 as the last step.
Merge all dependabot PRs not looking at the CI status, anyway the CI is red right now.

@bdraco bdraco marked this pull request as ready for review November 19, 2024 22:19
@bdraco
Copy link
Member Author

bdraco commented Nov 19, 2024

I can't figure out why they are failing so I'm going to mark them as xfail for now and get the CI passing, then we can figure out whats going wrong
#926

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (06cc2a1) to head (0d4392b).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   81.10%   80.75%   -0.35%     
==========================================
  Files          24       24              
  Lines        1434     1434              
  Branches      256      206      -50     
==========================================
- Hits         1163     1158       -5     
- Misses        177      184       +7     
+ Partials       94       92       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bdraco bdraco merged commit fb2ed4b into main Nov 19, 2024
12 checks passed
@bdraco bdraco deleted the drop_python_38 branch November 19, 2024 22:38
@asvetlov
Copy link
Member

Wow!
It's green now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants