-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 support #924
Conversation
At some point deps changed and 3.11 no longer passes last good run https://github.com/aio-libs/aiodocker/actions/runs/11209825300/job/31155665077 |
good Successfully installed MarkupSafe-2.1.5 aiodocker-0.1.dev1+g06cc2a1 aiohappyeyeballs-2.4.3 aiohttp-3.10.5 aiosignal-1.3.1 async-timeout-4.0.3 attrs-24.2.0 cattrs-24.1.2 certifi-2024.8.30 cfgv-3.4.0 charset-normalizer-3.3.2 click-8.1.7 codecov-2.1.13 coverage-7.6.1 distlib-0.3.8 exceptiongroup-1.2.2 filelock-3.16.1 frozenlist-1.4.1 identify-2.6.1 idna-3.10 iniconfig-2.0.0 jinja2-3.1.4 lsprotocol-2023.0.1 multidict-6.0.5 mypy-1.11.2 mypy-extensions-1.0.0 nodeenv-1.9.1 packaging-24.1 platformdirs-4.3.6 pluggy-1.5.0 pre-commit-4.0.0 pygls-1.3.1 pytest-8.3.2 pytest-asyncio-0.24.0 pytest-cov-5.0.0 pytest-sugar-1.0.0 pyyaml-6.0.2 requests-2.32.3 ruff-0.6.3 ruff-lsp-0.0.54 termcolor-2.5.0 tomli-2.0.2 towncrier-24.8.0 typing-extensions-4.12.2 urllib3-2.2.3 virtualenv-20.26.6 yarl-1.11.1 broken Successfully installed MarkupSafe-3.0.0 aiodocker-0.1.dev1+g06cc2a1 aiohappyeyeballs-2.4.3 aiohttp-3.10.5 aiosignal-1.3.1 async-timeout-4.0.3 attrs-24.2.0 cattrs-24.1.2 certifi-2024.8.30 cfgv-3.4.0 charset-normalizer-3.3.2 click-8.1.7 codecov-2.1.13 coverage-7.6.1 distlib-0.3.8 filelock-3.16.1 frozenlist-1.4.1 identify-2.6.1 idna-3.10 iniconfig-2.0.0 jinja2-3.1.4 lsprotocol-2023.0.1 multidict-6.0.5 mypy-1.11.2 mypy-extensions-1.0.0 nodeenv-1.9.1 packaging-24.1 platformdirs-4.3.6 pluggy-1.5.0 pre-commit-4.0.0 pygls-1.3.1 pytest-8.3.2 pytest-asyncio-0.24.0 pytest-cov-5.0.0 pytest-sugar-1.0.0 pyyaml-6.0.2 requests-2.32.3 ruff-0.6.3 ruff-lsp-0.0.54 termcolor-2.5.0 towncrier-24.8.0 typing-extensions-4.12.2 urllib3-2.2.3 virtualenv-20.26.6 yarl-1.11.1 |
I don't see anything obvious that explains the failure |
Thanks for taking care! |
I can't figure out why they are failing so I'm going to mark them as xfail for now and get the CI passing, then we can figure out whats going wrong |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #924 +/- ##
==========================================
- Coverage 81.10% 80.75% -0.35%
==========================================
Files 24 24
Lines 1434 1434
Branches 256 206 -50
==========================================
- Hits 1163 1158 -5
- Misses 177 184 +7
+ Partials 94 92 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Wow! |
Drop Python 3.8 support as it has reached EOL and all the deps no longer support it causing all the dependabot PRs to fail which means we have no visibility if the CI is working or upstream changes are causing incompatibilities.