Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable writelines for test_write_large_payload_deflate_compression_data_in_eof #10423

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Disable writelines for test_write_large_payload_deflate_compression_data_in_eof #10423

merged 2 commits into from
Feb 6, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 6, 2025

We have a writelines version of this test, test_write_large_payload_deflate_compression_data_in_eof_writelines, which should have writelines enabled, but for this version, writelines should always be disabled

This test would fail with CPython 3.12.9+ or 3.13.2+

fixes #10421

@bdraco
Disable writelines for fix_test_write_large_payload_deflate_compressi…
41cb3ab 
…on_data_in_eof

We have a writelines version of this test, test_write_large_payload_deflate_compression_data_in_eof_writelines,
which should have writelines enabled, but for this version, writelines should always be disabled
@bdraco bdraco requested a review from asvetlov as a code owner February 6, 2025 14:56
@bdraco bdraco added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Feb 6, 2025
@bdraco bdraco requested a review from webknjaz as a code owner February 6, 2025 14:57
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 6, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (e6ed541) to head (c413d82).
Report is 5 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10423      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files         122      122              
  Lines       37125    37122       -3     
  Branches     2044     2044              
==========================================
- Hits        36669    36665       -4     
- Misses        316      317       +1     
  Partials      140      140
Flag Coverage Δ
CI-GHA 98.65% <100.00%> (-0.01%) ⬇️
OS-Linux 98.34% <100.00%> (-0.01%) ⬇️
OS-Windows 96.24% <100.00%> (-0.01%) ⬇️
OS-macOS 97.45% <100.00%> (-0.02%) ⬇️
Py-3.10.11 97.33% <100.00%> (-0.02%) ⬇️
Py-3.10.16 97.91% <100.00%> (-0.01%) ⬇️
Py-3.11.11 97.99% <100.00%> (-0.02%) ⬇️
Py-3.11.9 97.42% <100.00%> (-0.01%) ⬇️
Py-3.12.8 98.43% <100.00%> (-0.01%) ⬇️
Py-3.13.1 98.41% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.23% <100.00%> (-0.01%) ⬇️
Py-3.9.21 97.79% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.37% <100.00%> (-0.01%) ⬇️
VM-macos 97.45% <100.00%> (-0.02%) ⬇️
VM-ubuntu 98.34% <100.00%> (-0.01%) ⬇️
VM-windows 96.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #10423 will not alter performance

Comparing fix_test_write_large_payload_deflate_compression_data_in_eof (c413d82) with master (e6ed541)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco merged commit 51daf71 into master Feb 6, 2025
41 checks passed
@bdraco bdraco deleted the fix_test_write_large_payload_deflate_compression_data_in_eof branch February 6, 2025 16:27
@patchback Patchback
Copy link
Contributor

patchback bot commented Feb 6, 2025 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/51daf7190e7674773c22011a4e443df8b5e66437/pr-10423

Backported as #10429

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 6, 2025
@bdraco @patchback
Disable writelines for test_write_large_payload_deflate_compression_d…
0841d8c 
…ata_in_eof (#10423)

(cherry picked from commit 51daf71)
@patchback patchback bot mentioned this pull request Feb 6, 2025
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Feb 6, 2025 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/51daf7190e7674773c22011a4e443df8b5e66437/pr-10423

Backported as #10430

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 6, 2025
@bdraco @patchback
Disable writelines for test_write_large_payload_deflate_compression_d…
642fc99 
…ata_in_eof (#10423)

(cherry picked from commit 51daf71)
@patchback patchback bot mentioned this pull request Feb 6, 2025
Merged
bdraco pushed a commit that referenced this pull request Feb 6, 2025
@patchback
[PR #10423/51daf719 backport][3.12] Disable writelines for test_write…
cae5b2e 
…_large_payload_deflate_compression_data_in_eof (#10430)

Co-authored-by: J. Nick Koston <[email protected]>
fixes #10421
bdraco pushed a commit that referenced this pull request Feb 7, 2025
@patchback
[PR #10423/51daf719 backport][3.11] Disable writelines for test_write…
cf19b04 
…_large_payload_deflate_compression_data_in_eof (#10429)

Co-authored-by: J. Nick Koston <[email protected]>
fixes #10421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
1 participant
@bdraco