Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Attempt to avoid copy on read #10425

Closed
wants to merge 1 commit into from
Closed

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 6, 2025

This may already be optimized under the hood, but codspeed will tell us

This may already be optimized under the hood, but codspeed will tell us
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (0d44b6a) to head (e6dce99).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10425      +/-   ##
==========================================
- Coverage   98.76%   98.74%   -0.02%     
==========================================
  Files         122      122              
  Lines       37116    37116              
  Branches     2044     2044              
==========================================
- Hits        36656    36649       -7     
- Misses        320      324       +4     
- Partials      140      143       +3     
Flag Coverage Δ
CI-GHA 98.63% <100.00%> (-0.02%) ⬇️
OS-Linux 98.32% <100.00%> (-0.02%) ⬇️
OS-Windows 96.19% <100.00%> (-0.07%) ⬇️
OS-macOS 97.44% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.33% <100.00%> (ø)
Py-3.10.16 97.91% <100.00%> (ø)
Py-3.11.11 97.99% <100.00%> (ø)
Py-3.11.9 97.42% <100.00%> (ø)
Py-3.12.8 98.43% <100.00%> (ø)
Py-3.13.1 98.41% <100.00%> (ø)
Py-3.9.13 96.93% <100.00%> (-0.31%) ⬇️
Py-3.9.21 97.79% <100.00%> (ø)
Py-pypy7.3.16 ?
VM-macos 97.44% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.32% <100.00%> (-0.02%) ⬇️
VM-windows 96.19% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #10425 will not alter performance

Comparing try_to_avoid_copy_on_read (e6dce99) with master (0d44b6a)

Summary

✅ 47 untouched benchmarks

@bdraco
Copy link
Member Author

bdraco commented Feb 6, 2025

Yeah its already optimized in the bytes join

@bdraco bdraco closed this Feb 6, 2025
@bdraco bdraco deleted the try_to_avoid_copy_on_read branch February 6, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant