-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for streaming API iter_chunks #10426
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10426 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 122 122
Lines 37116 37135 +19
Branches 2044 2046 +2
=======================================
+ Hits 36656 36675 +19
Misses 320 320
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10426 will not alter performanceComparing Summary
Benchmarks breakdown
|
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10427 🤖 @patchback |
(cherry picked from commit fae142f)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10428 🤖 @patchback |
(cherry picked from commit fae142f)
…ter_chunks (#10427) Co-authored-by: J. Nick Koston <[email protected]>
…ter_chunks (#10428) Co-authored-by: J. Nick Koston <[email protected]>
Benchmark to demo the benefit of
iter_chunks
overread
Most of the time is spent in getting the data from llhttp into python objects, but its still significantly faster to use
iter_chunks
vsread
because it avoids another copy.