Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support #7315

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
needs: gen_llhttp
strategy:
matrix:
pyver: [3.7, 3.8, 3.9, '3.10']
pyver: [3.7, 3.8, 3.9, '3.10', '3.11']
no-extensions: ['', 'Y']
os: [ubuntu, macos, windows]
experimental: [false]
Expand All @@ -152,15 +152,15 @@ jobs:
os: ubuntu
experimental: false
- os: macos
pyver: "3.11.0-alpha - 3.11.0"
pyver: "3.12-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is not even starting any tests. Maybe this is not a valid pyver value? Probably better to use a similar range to what we had before.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has recently changes in the setup-python action, we can now use the normal version indicator.

Suggested change
pyver: "3.12-dev"
pyver: "3.12"

experimental: true
no-extensions: 'Y'
- os: ubuntu
pyver: "3.11.0-alpha - 3.11.0"
pyver: "3.12-dev"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pyver: "3.12-dev"
pyver: "3.12"

experimental: false
no-extensions: 'Y'
- os: windows
pyver: "3.11.0-alpha - 3.11.0"
pyver: "3.12-dev"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pyver: "3.12-dev"
pyver: "3.12"

experimental: true
no-extensions: 'Y'
fail-fast: true
Expand Down
1 change: 1 addition & 0 deletions CHANGES/7229.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use cython 3.0.0b2, fixing Python 3.12 compatibility.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use cython 3.0.0b2, fixing Python 3.12 compatibility.
Use cython 3.0.0, fixing Python 3.12 compatibility.

2 changes: 1 addition & 1 deletion requirements/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ proxy-py==2.4.4rc3
# via -r requirements/test.txt
py==1.11.0
# via pytest
pycares==4.1.2
pycares==4.3.0
# via aiodns
pycparser==2.20
# via cffi
Expand Down
2 changes: 1 addition & 1 deletion requirements/cython.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
-r multidict.txt
-r typing-extensions.txt # required for parsing aiohttp/hdrs.py by tools/gen.py
cython==0.29.32
cython==3.0.0b3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is now stable: https://github.com/cython/cython/releases/tag/3.0.0

Suggested change
cython==3.0.0b3
cython==3.0.0

2 changes: 2 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ classifiers =
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12

Topic :: Internet :: WWW/HTTP

Expand Down