Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Concatenate to Paramspec so that Class Methods get correctly defined #639

Open
wants to merge 1 commit into
base: paramspec
Choose a base branch
from

Conversation

Vizonex
Copy link

@Vizonex Vizonex commented Jan 24, 2025

I Added Concenate to Paramspec to Fix Some Behaviors with Typehinting Class Methods inside VS Code and hopefully other ides

These changes correctly type hint the parameters inside of the asynchronous functions when throwing in parameters allowing pywright to properly hint at what to put into the function.

Here's an example of it working on my pc for class-methods
image

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Dreamsorcerer
Copy link
Member

Thanks, I'll try and look at this next week.

@Vizonex
Copy link
Author

Vizonex commented Jan 24, 2025

Thanks, I'll try and look at this next week.

No Problem, take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants