Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take statsd host and port from environment if missing in the config. #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

porridge
Copy link

Fixes: #28

@porridge
Copy link
Author

I manually tested that:

  • omitting the settings from both environment and config properties falls back to localhost:8125
  • omitting settings from config properties but providing them in the environment picks up the latter

Please let me know whether I should bump version (and to what, since master seem to be 0.5.2 but there is some mysterious 0.5.3 at https://bintray.com/airbnb/jars/kafka-statsd-metrics2/0.5.3#files/com%2Fairbnb%2Fkafka-statsd-metrics2%2F0.5.3).

@porridge
Copy link
Author

friendly ping, anyone? @ziliangpeng ?

@porridge
Copy link
Author

friendly ping again, @ziliangpeng @alexism @parasitew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant