-
-
Notifications
You must be signed in to change notification settings - Fork 19
A second MA example #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe documentation in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
research/MA.md (2)
29-31
: Specify Language for Fenced Code Blocks
Multiple fenced code blocks in this document (e.g. at lines 29, 33, 37, 41, 45, 49, and 53) are missing language identifiers. To adhere to markdownlint guidelines (MD040) and improve clarity (and potential syntax highlighting in some renderers), consider adding a language specifier—for example, usetext
if these blocks are intended as raw output examples.Also applies to: 33-35, 37-39, 41-43, 45-47, 49-51, 53-55
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
29-29: Fenced code blocks should have a language specified
null(MD040, fenced-code-language)
67-68
: Clarify Decoder Capabilities and Deflate Header Considerations
The updated note stating that libacars appears to have a decoder capable of partially reassembling and decoding the messages is clear and useful. In light of the PR objectives—where it is mentioned that the content is neither base64 nor Ascii85—it may be helpful to explicitly note that this example could indicate nonstandard deflate headers. Such a note would further assist decoder developers in troubleshooting header issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
research/MA.md
(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
research/MA.md
29-29: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
33-33: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
37-37: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
41-41: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
45-45: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
49-49: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
53-53: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
🔇 Additional comments (1)
research/MA.md (1)
25-28
: New Example 2 Addition
The new "Example 2 (from D-AIXQ, an A350-900)" section is a valuable addition that provides extra context for decoding MIAM messages. It aids future decoder implementations by expanding the range of provided examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for the addition!
It's not base64, it's not seemingly Ascii85 (or the deflate headers are off), but I am adding it as an example to help future decorders
Summary by CodeRabbit