Migrate to Jetty 12.0.7 EE10 #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @electrum |
wendigo
force-pushed
the
serafin/jetty-12
branch
2 times, most recently
from
7e75bfc to
9ad493a
Compare
|
oooohhhh.. I like it. Will have to see about this in trino-gateway in the future. |
wendigo
force-pushed
the
serafin/jetty-12
branch
2 times, most recently
from
17386f3 to
80649e4
Compare
wendigo
force-pushed
the
serafin/jetty-12
branch
from
80649e4 to
1354201
Compare
wendigo
force-pushed
the
serafin/jetty-12
branch
4 times, most recently
from
24c6ceb to
e460975
Compare
wendigo
force-pushed
the
serafin/jetty-12
branch
2 times, most recently
from
be3c2d2 to
de77b38
Compare
wendigo
force-pushed
the
serafin/jetty-12
branch
4 times, most recently
from
e279ee0 to
a4ad4f2
Compare
joakime
reviewed
Feb 22, 2024
electrum
reviewed
Feb 22, 2024
http-client/src/test/java/io/airlift/http/client/AbstractHttpClientTest.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/jetty-12
branch
from
43e1d3a to
3128b9b
Compare
wendigo
force-pushed
the
serafin/jetty-12
branch
2 times, most recently
from
ac94741 to
9d7cac1
Compare
wendigo
force-pushed
the
serafin/jetty-12
branch
3 times, most recently
from
f87c70d to
446d2f7
Compare
|
Jetty 12.0.7 was released to maven central (https://github.com/jetty/jetty.project/releases/tag/jetty-12.0.7). This PR is now ready to be reviewed @electrum |
wendigo
force-pushed
the
serafin/jetty-12
branch
from
90292b7 to
40f1f8c
Compare
|
@Randgalt do you want to take a look as well? |
wendigo
force-pushed
the
serafin/jetty-12
branch
2 times, most recently
from
9377bd5 to
7a3c4ae
Compare
electrum
reviewed
Mar 7, 2024
electrum
approved these changes
Mar 7, 2024
http-server/src/main/java/io/airlift/http/server/HttpServer.java
Outdated
Show resolved
Hide resolved
http-server/src/main/java/io/airlift/http/server/HttpServerModule.java
Outdated
Show resolved
Hide resolved
http-server/src/main/java/io/airlift/http/server/testing/TestingHttpServer.java
Outdated
Show resolved
Hide resolved
http-server/src/test/java/io/airlift/http/server/testing/AbstractTestTestingHttpServer.java
Show resolved
Hide resolved
dain
reviewed
Mar 7, 2024
http-server/src/main/java/io/airlift/http/server/HttpServerProvider.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/jetty-12
branch
from
7a3c4ae to
fb12b79
Compare
It requires maven 3.9.5 which makes it incompatible with the default maven version installed by github actions' setup-java and with the latest maven daemon (mvnd) version.
- Rework request log generation - Fix incorrect handler usages - Move to EE10 container (servlet 6.0) - Improve request log
wendigo
force-pushed
the
serafin/jetty-12
branch
from
fb12b79 to
aa3c855
Compare
|
@electrum review addressed. PTAL once again. |
This is static behaviour - either application supports virtual threads or not. Hence this is not user-configurable.
wendigo
force-pushed
the
serafin/jetty-12
branch
from
aa3c855 to
aa37036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves airlift to Jetty 12.0.7 and EE10 (Servlet 6.0)