Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING, this breaks backward compatibility. branch-head below 63 will not work.
Not sure how to handle this but webrtc 63 do not work with the cmake script anymore.
The WebRTC team has moved all headers from
out/webrtc/src/webrtc
toout/webrtc/src
.This commit install the header from the right location.
However,
CMakeModules/Templates/LibWebRTCConfig.cmake.in
has been modified to include both theINSTALL_INCLUDE_DIR
andINSTALL_INCLUDE_DIR/webrtc
.This is because we still want to include webRTC header this way from our program:
#include <webrtc/somefile.h>
but then the header from webrtc might include other webrtc header this way#include <someotherfile.h
.I'm not sure how to handle the backward compatibility and the small hack with the include. Because of this I advise not to merge this PR. Someone can still get inspiration from it to make it better though.