client: allow to provision Google BYOC [MILK-135] #385
+65
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prime541
force-pushed
the
guillaume.giffard-MILK-135-GCP-BYOC-image-sharing
branch
2 times, most recently
from
150e88c to
b4dd6cb
Compare
- replace 'pip install -e .[dev]' by 'make install-py' - create a default 'make' target to locally run: install-py, validate-style, lint and test [MILK-135]
Prime541
force-pushed
the
guillaume.giffard-MILK-135-GCP-BYOC-image-sharing
branch
from
b4dd6cb to
2d41bea
Compare
|
Moving back to This change is available in the |
heikju
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provision a Google BYOC we need to pass the customer's privilege-bearing service account ID, so we can later impersonate it and start service node instances in the Google account of the customer.
Also, ease local testing:
MILK-135