Fix SetThreadName on Linux #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetThreadName set the name of current thread, where it is expected to set the target thread. This change will store the name if the thread is not started. Then, set the name after the thread is created. Also fix missing upper 32-bit of the pointer on AMD64.
norihiro
force-pushed
the
fix-set-thread-name
branch
from
1503e85 to
33048cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SetThreadName set the name of current thread, where it is expected to set the target thread. This change will store the name if the thread is not started. Then, set the name after the thread is created.
The original code uses
prctlto set the name. However, the cast tounsigned longwill loose the upper 32-bit of the 64-bit pointer on 64-bit system. This PR also fix to usepthread_setname_npto fix the issue.ntv2/ajalibraries/ajabase/system/linux/threadimpl.cpp
Line 612 in 2e64749
Step to reproduce the issue
OS: Fedora Linux 34
topWithout this fix,
topshowsAJA Video Outpuas the name of the main thread of OBS Studio.With this fix,
topshows the original name of the thread. When hitH, stillAJA Video Outpuappears as another thread.