Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MultiProgressBarAnimation.kt): startTime #246

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Wujiaxuan007
Copy link
Contributor

Fix: Correct startTime Initialization in ProgressTaskImpl

Summary

This PR fixes an issue where startTime was incorrectly set to pauseTime, ensuring accurate task progress tracking and speed estimation.

Changes

Updated:

val startTime = status.pauseTime ?: now

to:

val startTime = status.startTime ?: now

@Wujiaxuan007 Wujiaxuan007 force-pushed the bugfix/progress-start-time branch from 7d5c908 to 36b691a Compare December 30, 2024 04:58
@Wujiaxuan007 Wujiaxuan007 force-pushed the bugfix/progress-start-time branch from 36b691a to 397562b Compare December 30, 2024 05:07
Copy link
Owner

@ajalt ajalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ajalt ajalt enabled auto-merge (squash) January 2, 2025 17:51
@ajalt ajalt merged commit efbec56 into ajalt:master Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants