fix: ensures that DecCoin doesn't loose precision for very long numbers #194
+77
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalniy
force-pushed
the
fix/dec-coin-encoding
branch
2 times, most recently
from
582f255 to
c87b9f1
Compare
stalniy
force-pushed
the
fix/dec-coin-encoding
branch
from
c87b9f1 to
38905dd
Compare
stalniy
force-pushed
the
fix/dec-coin-encoding
branch
from
9f1e13c to
557a9ea
Compare
ygrishajev
approved these changes
Feb 27, 2025
troian
reviewed
Feb 27, 2025
| @@ -41,6 +41,7 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@cosmjs/math": "^0.33.0", | |||
There was a problem hiding this comment.
need to check if this version is compatible with sdk-47.
go implementation uses math package of version v1.3.0, which is not latest
troian
reviewed
Feb 27, 2025
| import * as minimal from "protobufjs/minimal"; | ||
| import { Reader } from "protobufjs/minimal"; | ||
|
|
||
| import * as coin from "../../../../generated/cosmos/base/v1beta1/coin.original"; | ||
| import { DecCoin } from "../../../../generated/cosmos/base/v1beta1/coin.original"; | ||
|
|
||
| const originalEncode = coin.DecCoin.encode; | ||
| const PRECISION = 18; |
There was a problem hiding this comment.
Lets add a comment the value has been derrived from here https://github.com/cosmos/cosmos-sdk/blob/25b14c3caa2ecdc99840dbb88fdb3a2d8ac02158/math/dec.go#L21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Current implementation relies on
parseInt+ devision which will loose precision for very long numbersWhat