Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change logo for dark mode #693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: change logo for dark mode #693

wants to merge 2 commits into from

Conversation

ShinySyntax
Copy link

No description provided.

@ShinySyntax ShinySyntax requested a review from a team as a code owner January 21, 2025 19:20
@ShinySyntax ShinySyntax mentioned this pull request Jan 21, 2025
Open
baktun14
baktun14 requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are svg's with .png extension.

@baktun14
Copy link
Contributor

So these new logos will be shown in both light/dark mode? Also, you need to sign your commits for it to be mergeable.

@ShinySyntax
Copy link
Author

Sure, these new logos will be shown in both light/ dark mode

@baktun14
Copy link
Contributor

How does it look in light mode? Have you tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baktun14 baktun14 baktun14 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShinySyntax @baktun14