refactor: extracts certificate validation into a separate class #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baktun14
previously approved these changes
Jan 30, 2025
baktun14
reviewed
Jan 30, 2025
stalniy
force-pushed
the
refactor/cert-validator
branch
from
5701f8c to
e77a83d
Compare
baktun14
reviewed
Jan 31, 2025
baktun14
previously approved these changes
Jan 31, 2025
stalniy
force-pushed
the
refactor/cert-validator
branch
from
e77a83d to
f591481
Compare
baktun14
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To reuse for websocket certificate validation, refs #170
What
certandkeyfrom Proxy agent cache because we do not want to reuse the same client's cert for all provider proxy clients (it's a bug)