Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest version. #1623

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Update dependencies to latest version. #1623

merged 3 commits into from
Jun 27, 2022

Conversation

counter2015
Copy link
Contributor

References #1622

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, also fixing some warnings, thank you!

benchmark-java/build.sbt Show resolved Hide resolved
@counter2015
Copy link
Contributor Author

counter2015 commented Jun 23, 2022

Some CI checks failed.

protoc-gen-js not found in path.

Error:  x gen-scala-server/06-compatibility-plugins 
Error:   Cause of test exception: {line 1}  Command failed: compile failed

Error:  protoc-gen-js: program not found or is not executable
Error:  Please specify a program using absolute path or make sure the program is available in your PATH system variable
Error:  --js_out: protoc-gen-js: Plugin failed with status code 1.

I'm not sure how to fix it.

And another one is about gradle test.

example.myapp.helloworld.ErrorReportingSpec > initializationError FAILED
    java.lang.IllegalStateException: You are using version 2.6.19 of Akka, but it appears you (perhaps indirectly) also depend on older versions of related artifacts. 

You can solve this by adding an explicit dependency on version 2.6.19 of the [akka-testkit, akka-stream-testkit] artifacts to your project. Here's a complete collection of detected artifacts: (2.6.9, [akka-stream-testkit, akka-testkit]), (2.6.19, [akka-actor, akka-discovery, akka-protobuf-v3, akka-stream]). 

See also: https://doc.akka.io/docs/akka/current/common/binary-compatibility-rules.html#mixed-versioning-is-not-allowed

The latest version of akka-http-cors is 1.1.3 which uses akka 2.6.18.

This may also cause version conflict on gradle plugin test, I'm not familiar with gradle, should we add an explicit dependency on version 2.6.19 ?

Looks like there's no code to use it on this test, I found it only in akka-grpc-runtime. Or can we remove it safely from this test?

implementation group: 'ch.megard', name: "akka-http-cors_${scalaBinaryVersion}", version: '1.1.0'

@counter2015 counter2015 requested a review from raboof June 23, 2022 03:12
@raboof
Copy link
Member

raboof commented Jun 24, 2022

protoc-gen-js not found in path.

Error: x gen-scala-server/06-compatibility-plugins
Error: Cause of test exception: {line 1} Command failed: compile failed

Error: protoc-gen-js: program not found or is not executable
Error: Please specify a program using absolute path or make sure the program is available in your PATH system variable
Error: --js_out: protoc-gen-js: Plugin failed with status code 1.

I'm not sure how to fix it.

Strange. Would be good to see what changed that causes this problem: is this a new requirement or was this requirement already there and did something cause the command to be no longer available?

The latest version of akka-http-cors is 1.1.3 which uses akka 2.6.18.

This should be no problem: because we maintain binary compatibility, you can use a library that was written for 2.6.18 in a project that uses a later version in the 2.6.x series. This requiremes that you do that update 'across the board' though, so in this case make sure akka-testkit and akka-stream-testkit are also updated.

Looks like there's no code to use it on this test, I found it only in akka-grpc-runtime. Or can we remove it safely from this test?

If it's already a transitive dependency then indeed I don't think it should be needed to pull it in explicitly on that test - though I'm not sure if it'd fix that problem.

@counter2015
Copy link
Contributor Author

counter2015 commented Jun 24, 2022

It seems that they remove protoc-gen-js ? I found the issue here.

Last CI said

NonBalancingIntegrationSpecNetty

[info] - should send requests to a single endpoint that is restarted in the middle *** FAILED *** (175 milliseconds)
[info]   The future returned an exception of type: io.grpc.StatusRuntimeException, with message: UNAVAILABLE: io exception. (NonBalancingIntegrationSpec.scala:85)

But I cant reproduct it from my machine

sbt:akka-grpc-interop-tests> projects
[info] In file:/Users/counter/dev/akka-grpc/
[info] 	   akka-grpc
[info] 	   akka-grpc-codegen
[info] 	   akka-grpc-docs
[info] 	 * akka-grpc-interop-tests
[info] 	   akka-grpc-maven-plugin
[info] 	   akka-grpc-plugin-tester-java
[info] 	   akka-grpc-plugin-tester-scala
[info] 	   akka-grpc-runtime
[info] 	   akka-grpc-scalapb-protoc-plugin
[info] 	   benchmarks
[info] 	   sbt-akka-grpc

sbt:akka-grpc-interop-tests> +testOnly akka.grpc.scaladsl.NonBalancingIntegrationSpecNetty
....
[info] Setting Scala version to 2.13.8 on 6 projects.
[info] Excluded 5 projects, run ++ 2.13.8 -v for more details.
[info] Reapplying settings...
....
[info] NonBalancingIntegrationSpecNetty:
[info] Using pick-first (non load balanced clients) - netty
[info] - should send requests to a single endpoint (1 second, 976 milliseconds)
[info] - should send requests to a single endpoint that is restarted in the middle (247 milliseconds)
[info] - should re-discover endpoints on failure (5 seconds, 67 milliseconds)
[info] - should select the right endpoint among invalid ones (458 milliseconds)
[info] - should eventually fail when no valid endpoints are provided (1 second, 177 milliseconds)
[info] - should not fail when no valid endpoints are provided but no limit on attempts is set (10 seconds, 8 milliseconds)
[info] Run completed in 19 seconds, 812 milliseconds.
[info] Total number of tests run: 6
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 6, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

@raboof
Copy link
Member

raboof commented Jun 24, 2022

NonBalancingIntegrationSpecNetty

Hmm, that might be a flakey test, I've re-triggered the failed jobs.

@counter2015
Copy link
Contributor Author

It seems that the latest protoc version 3.21.1 released is not prepared yet
grpc/grpc-web#1251 (comment)

I will downgrade the version to 3.20.1.

@counter2015
Copy link
Contributor Author

@raboof should I rebase the commit ?

@raboof
Copy link
Member

raboof commented Jun 27, 2022

@raboof should I rebase the commit ?

No, this is fine, I can squash&merge. Thanks for the contribution!

@raboof raboof merged commit 5448baa into akka:main Jun 27, 2022
@counter2015 counter2015 deleted the update/dependency branch June 27, 2022 12:35
@raboof raboof mentioned this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants