-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to latest version. #1623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, also fixing some warnings, thank you!
Some CI checks failed. protoc-gen-js not found in path.
I'm not sure how to fix it. And another one is about gradle test.
The latest version of akka-http-cors is 1.1.3 which uses akka 2.6.18. This may also cause version conflict on gradle plugin test, I'm not familiar with gradle, should we add an explicit dependency on version 2.6.19 ? Looks like there's no code to use it on this test, I found it only in akka-grpc-runtime. Or can we remove it safely from this test?
|
Strange. Would be good to see what changed that causes this problem: is this a new requirement or was this requirement already there and did something cause the command to be no longer available?
This should be no problem: because we maintain binary compatibility, you can use a library that was written for 2.6.18 in a project that uses a later version in the 2.6.x series. This requiremes that you do that update 'across the board' though, so in this case make sure akka-testkit and akka-stream-testkit are also updated.
If it's already a transitive dependency then indeed I don't think it should be needed to pull it in explicitly on that test - though I'm not sure if it'd fix that problem. |
It seems that they remove Last CI said
But I cant reproduct it from my machine
|
Hmm, that might be a flakey test, I've re-triggered the failed jobs. |
It seems that the latest protoc version I will downgrade the version to 3.20.1. |
@raboof should I rebase the commit ? |
No, this is fine, I can squash&merge. Thanks for the contribution! |
References #1622