Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework/components - removes and simplifies components used #224

Merged
merged 107 commits into from
Oct 13, 2023

Conversation

AoifeHughes
Copy link
Contributor

Should satisfy #211 once ready

@AoifeHughes AoifeHughes added the documentation Improvements or additions to documentation label Sep 6, 2023
@AoifeHughes AoifeHughes self-assigned this Sep 6, 2023
@AoifeHughes AoifeHughes added the enhancement New feature or request label Oct 13, 2023
@AoifeHughes AoifeHughes marked this pull request as ready for review October 13, 2023 07:03
@coveralls
Copy link

coveralls commented Oct 13, 2023

Pull Request Test Coverage Report for Build 6505903683

  • 52 of 90 (57.78%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 83.098%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/view_utils.py 1 2 50.0%
eap_backend/eap_api/models.py 14 17 82.35%
eap_backend/eap_api/views.py 5 39 12.82%
Totals Coverage Status
Change from base Build 6493125885: -2.2%
Covered Lines: 1175
Relevant Lines: 1414

💛 - Coveralls

@AoifeHughes AoifeHughes merged commit b29e95c into main Oct 13, 2023
7 checks passed
@AoifeHughes AoifeHughes deleted the rework/components branch October 13, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants