You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following events trigger a re-calculation of the item identifiers:
Adding/Deleting Context.
Adding/Deleting Strategies.
Adding/Deleting Property Claims.
The new identifiers are written on the database. If the frontend re-renders the diagram, the ids should be reflected.
DO NOT MERGE UNLESS EXTENSIVE TESTING IS PERFORMED!
This is an emergency PR for unblocking @RichGriff for next workshop features: I've manually verified the changes work using the legacy front-end, but further testing is required, specially with the new frontend and corner-cases.
Automated tests are still pending. I will deliver them once the HackWeek is over.
Would it be possible for us to do a git rebase based on the ttw-conversion branch? It may be an easier way than trying to go via the main branch, which doesn't have any of the updates on the frontend from Rich?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following events trigger a re-calculation of the item identifiers:
The new identifiers are written on the database. If the frontend re-renders the diagram, the ids should be reflected.
DO NOT MERGE UNLESS EXTENSIVE TESTING IS PERFORMED!
This is an emergency PR for unblocking @RichGriff for next workshop features: I've manually verified the changes work using the legacy front-end, but further testing is required, specially with the new frontend and corner-cases.
Automated tests are still pending. I will deliver them once the HackWeek is over.