Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Updating identifiers when the diagram is modified #479

Conversation

cptanalatriste
Copy link
Collaborator

The following events trigger a re-calculation of the item identifiers:

  • Adding/Deleting Context.
  • Adding/Deleting Strategies.
  • Adding/Deleting Property Claims.

The new identifiers are written on the database. If the frontend re-renders the diagram, the ids should be reflected.

DO NOT MERGE UNLESS EXTENSIVE TESTING IS PERFORMED!

This is an emergency PR for unblocking @RichGriff for next workshop features: I've manually verified the changes work using the legacy front-end, but further testing is required, specially with the new frontend and corner-cases.

Automated tests are still pending. I will deliver them once the HackWeek is over.

@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9455924708

Details

  • 16 of 31 (51.61%) changed or added relevant lines in 2 files are covered.
  • 63 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 81.31%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/views.py 13 28 46.43%
Files with Coverage Reduction New Missed Lines %
eap_backend/eap_backend/settings.py 4 90.91%
eap_backend/eap_api/views.py 59 58.82%
Totals Coverage Status
Change from base Build 9380433823: 0.1%
Covered Lines: 1279
Relevant Lines: 1573

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9455928470

Details

  • 20 of 33 (60.61%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.31%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/views.py 20 33 60.61%
Totals Coverage Status
Change from base Build 9380433823: 0.1%
Covered Lines: 1279
Relevant Lines: 1573

💛 - Coveralls

@RichGriff
Copy link
Collaborator

RichGriff commented Jun 11, 2024

@cptanalatriste We shouldn't be merging this into main - it should be into develop but not until the frontend dev has been completed.

I will take a look at your branch, did you create that branch from develop ?

@cptanalatriste
Copy link
Collaborator Author

@cptanalatriste We shouldn't be merging this into main - it should be into develop but not until the frontend dev has been completed.

I will take a look at your branch, did you create that branch from develop ?

I branched from main

@RichGriff
Copy link
Collaborator

@cptanalatriste ah right okay. Will try and take your branch and merge it into the develop or another working branch to test the changes.

We'll have to cancel this pull request as we shouldn't be pushing into main unless its a release.

@kallewesterling
Copy link
Collaborator

Would it be possible for us to do a git rebase based on the ttw-conversion branch? It may be an easier way than trying to go via the main branch, which doesn't have any of the updates on the frontend from Rich?

@cptanalatriste
Copy link
Collaborator Author

These functional was already moved into develop as part of another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Story]: Standardised and Immutable Identifier Assignment for Assurance Case Elements
4 participants