Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixing ordering when updating identifiers #496

Merged
merged 8 commits into from
Jun 19, 2024

Conversation

cptanalatriste
Copy link
Collaborator

When traversing the case graph, we were obtaining case element lists (Contexts, Property Claims, ...) for updating without specifying ordering criteria. In this fix, we made sure when gathering these lists, they are sorted by primary key.

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9588739363

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 2 files are covered.
  • 77 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 82.593%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/models.py 1 2 50.0%
eap_backend/eap_api/views.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
eap_backend/eap_api/models.py 8 88.79%
eap_backend/eap_api/views.py 69 63.13%
Totals Coverage Status
Change from base Build 9585938904: 0.0%
Covered Lines: 1338
Relevant Lines: 1620

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9588742973

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 82.593%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eap_backend/eap_api/views.py 5 9 55.56%
Files with Coverage Reduction New Missed Lines %
eap_backend/eap_api/models.py 1 88.79%
eap_backend/eap_api/views.py 2 63.13%
Totals Coverage Status
Change from base Build 9585938904: 0.0%
Covered Lines: 1338
Relevant Lines: 1620

💛 - Coveralls

@cptanalatriste cptanalatriste merged commit 1b56e3e into develop Jun 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants