#99 Add QR generator and related tests in ksef-qr module #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new QR generator in the ksef-qr module that uses Google ZXing library for QR code generation. The generator includes methods for generating a verification link based on the environment, KSeF number, and invoice data, and for generating the actual QR code as an image. It also includes small unit tests to confirm the functionality.
karolbryzgiel
approved these changes
Dec 21, 2023
|
Opcjonalnie można umieścić przykład wykorzystania kodu generującego link weryfikacyjny oraz kod QR |
QR code generation within the QrGenerator class has been refactored to include a new output stream parameter for flexibility in saving generated barcodes. Custom exception 'BarcodeGenerationException' handling has also been introduced to categorize exceptions that occur during the barcode creation process. Furthermore, the previous exceptions have been replaced with this new custom one in the method signatures. In makes code more flexible if in the future, we need to change an underline library used for barcode generation.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new QR generator in the ksef-qr module that uses Google ZXing library for QR code generation. The generator includes methods for generating a verification link based on the environment, KSeF number, and invoice data, and for generating the actual QR code as an image. It also includes small unit tests to confirm the functionality.