fix submission issues 2022-10-25

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: ggredist
 Title: Scales, Geometries, and Extensions of 'ggplot2' for Election Mapping
-Version: 0.0.1
+Version: 0.0.2
 Authors@R: c(
     person("Cory", "McCartan", email = "[email protected]", role = "aut"),
     person("Christopher T.", "Kenny", email = "[email protected]", 

R/538.R

@@ -4,7 +4,8 @@
 #'
 #' @param ... additional arguments to `ggplot::scale_*` functions
 #'
-#' @md
+#' @return ggplot scale function
+#'
 #' @examples
 #' scale_fill_538()
 #' scale_color_538()

R/dra.R

@@ -2,6 +2,8 @@
 #'
 #' @param ... Arguments passed on to [ggplot2::discrete_scale()]
 #'
+#' @return ggplot scale function
+#'
 #' @examples
 #' library(ggplot2)
 #' data(oregon)

R/nature.R

@@ -2,6 +2,8 @@
 #'
 #' @param ... Arguments passed on to [ggplot2::discrete_scale()]
 #'
+#' @return ggplot scale function
+#'
 #' @examples
 #' library(ggplot2)
 #' data(oregon)

R/party.R

@@ -10,6 +10,8 @@
 #'   of exactly evenly spaced between the limits.
 #' @param ... Additional arguments to `ggplot::scale_*` functions
 #'
+#' @return ggplot scale function
+#'
 #' @examples
 #' library(ggplot2)
 #' data(oregon)

R/penn82.R

@@ -2,6 +2,8 @@
 #'
 #' @param ... Arguments passed on to [ggplot2::discrete_scale()]
 #'
+#' @return ggplot scale function
+#'
 #' @examples
 #' library(ggplot2)
 #' data(oregon)

R/polimap.R

@@ -2,6 +2,8 @@
 #'
 #' @param ... Arguments passed on to [ggplot2::discrete_scale()]
 #'
+#' @return ggplot scale function
+#'
 #' @examples
 #' library(ggplot2)
 #' data(oregon)

README.Rmd

@@ -45,7 +45,7 @@ ggplot(oregon, aes(group=cd_2020)) +
   theme_map()
 ```
 
-See more in [the reference](/ggredist/reference/).
+See more in [the reference](https://alarm-redist.org/ggredist/reference/index.html).
 
 
 ## Installation

README.md

@@ -27,26 +27,17 @@ ggplot(oregon, aes(group=cd_2020)) +
   # can then highlight towns and cities
   geom_places(state = 'OR') + 
   # we can overlay county boundaries and labels
-  geom_district(aes(group=county), linewidth=0.4, linetype="dashed", fill=NA) +
+  geom_district(aes(group=county), linewidth=0.2, linetype="dashed", fill=NA) +
   geom_district_text(aes(group=county, label=toupper(county)),
                      size=2.2, check_overlap=TRUE) +
   scale_fill_party_b(limits=c(0.4, 0.6)) +
   theme_map()
-#> Warning in grid.Call(C_stringMetric, as.graphicsAnnot(x$label)): font family not
-#> found in Windows font database
-
-#> Warning in grid.Call(C_stringMetric, as.graphicsAnnot(x$label)): font family not
-#> found in Windows font database
-#> Warning in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : font
-#> family not found in Windows font database
-
-#> Warning in grid.Call(C_textBounds, as.graphicsAnnot(x$label), x$x, x$y, : font
-#> family not found in Windows font database
 ```
 
 <img src="man/figures/README-example-1.png" width="100%" />
 
-See more in [the reference](/ggredist/reference/).
+See more in [the
+reference](https://alarm-redist.org/ggredist/reference/index.html).
 
 ## Installation
 

cran-comments.md

@@ -1,3 +1,9 @@
+## Resubmission
+This is a resubmission. I address the issues from the 2022-10-25 submission as follows:
+
+* Adds missing value entry to scales (`scale_538.Rd`, `scale_dra.Rd`, `scale_nature.Rd`, `scale_party.Rd`, `scale_penn82.Rd`, and `scale_polimap.Rd`).
+* Corrects broken link in `readme.md`.
+
 ## Test environments
 
 * local R installation (Windows 11), R 4.2.1