Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a non docker ansible deploy #1
base: main
Are you sure you want to change the base?
Add a non docker ansible deploy #1
Changes from all commits
99d8821
5bef7a5
7db7880
d093694
5c678a7
0e7d3c7
82e89fd
b11f653
23ad215
bda3959
ea8d4ed
14eac8d
f0de54c
f80d62e
145a4b5
23d8a33
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd separate basic requirements (as the apt packages) form the more specific quorum installation, just to make it easy to deploy separately using tags. We might want to install a new version of quorum but not launch the apt for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is how the deploy works now. The apt dependencies and the quorum installation are separated or i'm misunderstanding something?