feat: add low level support for 7702 #1193
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
| const implAddress = await account.getImplementationAddress(); | ||
| if ( | ||
| code === | ||
| "0x00000000000000000000000000000000000000000000000001ff00" + |
There was a problem hiding this comment.
This isn't right, it should be 0xef0100 ++ address
There was a problem hiding this comment.
you could do starts with 0xEF as a check since contracts can never be deployed with the EF byte
| } & Omit<CustomSource, "signTransaction" | "address">; | ||
| } & Omit< | ||
| CustomSource, | ||
| "signTransaction" | "address" | "experimental_signAuthorization" |
There was a problem hiding this comment.
one caveat here: viem by default will use current nonce to sign the 1559 transaction, and use nonce +1 to sign authorization tuple. if we support 4337, UO is not tracked by native nonce, but by EP's nonce tracking. That means we have to override the default nonce viem used current nonce.
There was a problem hiding this comment.
There was a problem hiding this comment.
alternatively, I think we can set delegate: true to skip incrementing the nonce
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily updates the
VERSIONacross multiple files and introduces a new middleware function for signing user operations, along with related type and interface adjustments.Detailed summary
VERSIONto"4.6.0"in multiple files.signAuthorizationmethod inSmartContractAccount.default7702UserOpSignermiddleware function.UserOperationRequestto include optionalauthorizationTuple.default7702UserOpSigner.