-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable twitter social auth #1230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobChangCA
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
December 17, 2024 21:07
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dphilipson
previously approved these changes
Dec 18, 2024
RobChangCA
force-pushed
the
rob/twitter
branch
from
December 20, 2024 15:42
60528f6
to
a4f5d07
Compare
RobChangCA
force-pushed
the
rob/twitter
branch
from
December 20, 2024 16:12
a4f5d07
to
11f941f
Compare
RobChangCA
force-pushed
the
rob/twitter
branch
from
December 20, 2024 16:56
11f941f
to
50ec540
Compare
RobChangCA
force-pushed
the
rob/twitter
branch
from
January 6, 2025 15:36
50ec540
to
2cd20ea
Compare
RobChangCA
requested review from
adamegyed,
howydev and
Zer0dot
as code owners
January 6, 2025 15:36
dphilipson
force-pushed
the
rob/twitter
branch
from
January 10, 2025 22:53
5624fbd
to
e892ac5
Compare
moldy530
previously approved these changes
Jan 23, 2025
moldy530
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)Setup:
You will need to follow the guide here to enable auth0 and twitter in your application. https://accountkit.alchemy.com/signer/authentication/auth0
Testing steps:
You should be able to toggle on and off twitter in the sidebar.
You should be able to sign in to twitter via the X button in the authcard.
PR-Codex overview
This PR focuses on integrating Twitter as an OAuth authentication method in the application, enhancing user connection options and updating related components to support this new feature.
Detailed summary
UserConnectionAvatar
to display Twitter nickname if available.Config
to include Twitter inoAuthMethods
.twitter.svg
for Twitter branding.sections.ts
for Twitter.TwitterIcon
component.AuthType
to includedisplayName
for social providers.getSocialProviderDisplayName
function for consistent display names.Authentication
component to toggle Twitter authentication.CompletingOAuth
to usegetSocialProviderDisplayName
for better user feedback.