chore: remove lint warnings #1272
Conversation
linnall
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
adamegyed,
howydev,
Zer0dot,
jaypaik and
Blu-J
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
linnall
changed the title
linnall
changed the title
linnall
changed the title
linnall
changed the title
linnall
changed the title
removed changes to docs for basic mav2 sdk due to extensive work needed to support docs under |
| .then(setUser) | ||
| .catch(console.error); | ||
| }, | ||
| [signer] |
There was a problem hiding this comment.
React Hook useCallback has an unnecessary dependency: 'signer'. Either exclude it or remove the dependency array. Outer scope values like 'signer' aren't valid dependencies because mutating them doesn't re-render the component.
|
|
||
| useEffect(() => { | ||
| // get the user if already logged in | ||
| signer.getAuthDetails().then(setUser); | ||
| }, []); | ||
| }, [signer]); |
There was a problem hiding this comment.
React Hook useEffect has an unnecessary dependency: 'signer'. Either exclude it or remove the dependency array. Outer scope values like 'signer' aren't valid dependencies because mutating them doesn't re-render the component.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on refactoring the
handleUserAuthandhandleIncomingURLfunctions in themagic-link-auth.tsxfile to utilizeuseCallback, improving performance by memoizing these functions.Detailed summary
handleUserAuthto useuseCallbackwithsigneras a dependency.handleIncomingURLto useuseCallbackwithhandleUserAuthas a dependency.handleIncomingURLfunction.