Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lint warnings #1272

Closed
wants to merge 12 commits into from
Closed

chore: remove lint warnings #1272

wants to merge 12 commits into from

Conversation

linnall
Copy link
Collaborator

@linnall linnall commented Jan 10, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on refactoring the handleUserAuth and handleIncomingURL functions in the magic-link-auth.tsx file to use useCallback, improving performance by memoizing these functions.

Detailed summary

  • Changed handleUserAuth to use useCallback for memoization.
  • Updated handleIncomingURL to use useCallback, adding handleUserAuth as a dependency.
  • Maintained the logic for extracting URL parameters and handling authentication.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 8:23pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 8:23pm

Copy link

graphite-app bot commented Jan 10, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@linnall linnall changed the title docs: updates usage of createSMAV2Account docs: updates usage of createSMAV2AccountClient Jan 10, 2025
@linnall linnall requested a review from avarobinson January 10, 2025 21:39
howydev
howydev previously approved these changes Jan 10, 2025
Copy link
Collaborator

@howydev howydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@linnall linnall changed the title docs: updates usage of createSMAV2AccountClient docs: updates usage of createSMAV2AccountClient and refactors to remove lint warnings Jan 10, 2025
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... were the changes you made to the reference/* files done manually?

Those files should be autogenerated, but they're not because they're under experimental. Does running yarn generate wipe them out? my guess is yea

@linnall linnall changed the title docs: updates usage of createSMAV2AccountClient and refactors to remove lint warnings [DO NOT MERGE] docs: updates usage of createSMAV2AccountClient and refactors to remove lint warnings Jan 10, 2025
@linnall linnall changed the title [DO NOT MERGE] docs: updates usage of createSMAV2AccountClient and refactors to remove lint warnings refactor: removes lint warnings Jan 11, 2025
@linnall linnall changed the title refactor: removes lint warnings refactor: remove lint warnings Jan 11, 2025
@linnall linnall changed the title refactor: remove lint warnings chore: remove lint warnings Jan 11, 2025
@linnall
Copy link
Collaborator Author

linnall commented Jan 21, 2025

Oh... were the changes you made to the reference/* files done manually?

Those files should be autogenerated, but they're not because they're under experimental. Does running yarn generate wipe them out? my guess is yea

removed changes to docs for basic mav2 sdk due to extensive work needed to support docs under /experimental

moldy530
moldy530 previously approved these changes Jan 23, 2025
@linnall
Copy link
Collaborator Author

linnall commented Feb 19, 2025

closing due to being too outdated

@linnall linnall closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants