-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add oauth support to react native signer #1273
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small comments, but generally LGTM
site/pages/reference/account-kit/signer/functions/getDefaultScopeAndClaims.mdx
Outdated
Show resolved
Hide resolved
site/pages/reference/account-kit/signer/functions/getOauthNonce.mdx
Outdated
Show resolved
Hide resolved
@@ -1,2 +1,3 @@ | |||
// eslint-disable-next-line import/extensions | |||
/* eslint-disable import/extensions */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't be ignoring these. I'm actually shocked it's building with these 🤔
does it not work if these are ... from "./signer.js"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so specifying the extension seems to throw Metro off and prevents the example apps from building, hence we removed the extension from this export.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR primarily enhances the OAuth functionality within the
account-kit
library, introducing new error handling, utility functions, and improved integration with the In-App Browser. It also refines existing components and adds support for new OAuth providers.Detailed summary
Buffer
polyfill inbuffer-polyfill.ts
.resolveRelativeUrl
utility function.OAuthProvidersError
and addedInAppBrowserUnavailableError
.oauthWithRedirect
andoauthWithPopup
methods inRNSignerClient
.RNAlchemySigner
to include OAuth functionalities.OAuthScreen
for user authentication via OAuth.getOauthProviderUrl
utility for generating OAuth URLs.oauth.ts
.package.json
files to include new dependencies and versions.