feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts #1287

adamegyed · 2025-01-23T01:41:40Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR updates the viem package version across multiple package.json files and introduces new functionalities related to signing authorizations and gas estimation in the aa-sdk and account-kit projects.

Detailed summary

Updated viem version from ^2.20.0 to ^2.22.6 in various package.json files.
Added signAuthorization method to LocalAccountSigner and BaseAlchemySigner.
Introduced default7702UserOpSigner and default7702GasEstimator middleware functions.
Updated createSMA7702AccountClient and related functionalities in smart-contracts.
Enhanced type definitions for user operations and authorization handling.
Updated documentation for new and modified methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-01-23T01:41:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 30, 2025 7:13pm
aa-sdk-ui-demo	❌ Failed (Inspect)			Jan 30, 2025 7:13pm

graphite-app · 2025-01-23T01:41:47Z

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

moldy530

this is looking good!

One thing missing is some client.test at a minimum (though would be great if we could extend it to installValidation.ts and have unit tests for installValidation.test.ts)

OOS for this PR is the naming I think, but calling it out here as @howydev and @linnall look at consolidating to the Prism naming as just looking at this PR it's clear that it'll be much better devex externally to have both a Prism account factory and Prism client factory for release

moldy530 · 2025-01-24T16:12:43Z

aa-sdk/core/src/middleware/defaults/7702gasEstimator.ts

+/**
+ * A middleware function to estimate the gas usage of a user operation with an optional custom gas estimator.
+ * This function is only compatible with accounts using EntryPoint v0.7.0.
+ *


we should add an @example block here as well and it should look like:

@example ```ts twoslash .... ```

the twoslash piece will ensure that the code is valid when the docs site is built AND add the on hover interaction to the docs

moldy530 · 2025-01-24T16:15:18Z

aa-sdk/core/src/middleware/defaults/7702gasEstimator.ts

+      );
+    }
+
+    // todo: this is currently overloading the meaning of the getImplementationAddress method, replace with a dedicated method or clarify intention in docs


discussed offline, but I think it's a good idea to allow passing an optional override to toSmartContractAccount for this

That methods intention is meant to return the address at which the logic for the SCA lives and I think that holds here:

proxies point to a different address than the SCA address

no proxy accounts should probably return the address of the SCA itself?

7702 returns the address containing the logic we're delegating to for the EOA

moldy530 · 2025-01-24T16:17:12Z

aa-sdk/core/src/middleware/defaults/7702signer.ts

+    // TODO: this isn't the cleanest because now the account implementation HAS to know that it needs to return an impl address
+    // even if the account is not deployed


Is there anyway to make that clearer? If we add the optional parameter mentioned above, then we could update the docs on toSmartContractAccount to highlight what that address is for?

We could also update the jsdoc for this middleware as well to make it clear that the account MUST return something when calling getImplementationAddress

I think this is an issue on the semantic meaning of "getImplementationAddress" - there's ambiguity of what the function does:

does it get the current implementation address from the account's proxy? <-- what it is default-initialized to

does it get the intended implementation address for a proxy?

does it get the intended delegation address for 7702? <-- what this middleware expects user to overwrite it to

We could try to do something with the type system to attempt to assert that this middleware is only added to a client for which the account provided has the definition overwritten. But that sounds super messy, so I'm not particularly inclined to do it.

I think the real fix for this is to:

define the getImplementationAddress to mean getting the intended implementation address, agnostic to SCA / 7702-upgraded EOA

Move the "current proxy implementation getter" to a utility function / utility action on a public client

moldy530 · 2025-01-24T16:17:31Z

aa-sdk/core/src/middleware/defaults/7702signer.ts

+/**
+ * Provides a default middleware function for signing user operations with a client account when using ERC-7702 to upgrade local accounts to smart accounts.
+ * If the SmartAccount doesn't support `signAuthorization`, then this just runs the provided `signUserOperation` middleware
+ *


same comment here, needs an @example tag which has twoslash enabled

moldy530 · 2025-01-24T16:19:18Z

aa-sdk/core/src/middleware/defaults/7702signer.ts

+    if (yParity === undefined) {
+      throw new Error("Invalid signature: missing yParity or v");
+    }


This seems like the responsibility of the signer probably no?

moldy530 · 2025-01-24T16:25:34Z

account-kit/smart-contracts/src/ma-v2/account/common/modularAccountV2Base.ts

+
+export type MAV2Account<
+  TSigner extends SmartAccountSigner = SmartAccountSigner
+> = SmartContractAccountWithSigner<"MAV2Account", TSigner, "0.7.0"> & {


I think this base type should probably be generic on source as well since source should be unique per instance (ie. the first generic parameter in SmartContractAccountWithSigner)

moldy530 · 2025-01-24T16:26:27Z

account-kit/smart-contracts/src/ma-v2/account/semiModularAccount7702.ts

+  signer: TSigner;
+  entryPoint?: EntryPointDef<"0.7.0", Chain>;
+  signerEntity?: SignerEntity;


oh yea I remember seeing this during hackathon and thinking it odd. Why can't we merge signer and signerEntity?

cc @howydev

moldy530 · 2025-01-24T16:26:49Z

account-kit/smart-contracts/src/ma-v2/account/semiModularAccount7702.ts

+/**
+ * Creates an SMAV2 account using defined parameters including chain, signer, salt, factory address, and more.
+ * Handles account initialization code, nonce generation, transaction encoding, and more to construct a modular account with optional validation hooks.
+ *


nit: add example here

moldy530 · 2025-01-24T16:27:23Z

account-kit/smart-contracts/src/ma-v2/client/sma7702.ts

+ * Creates a SMAv2 account client using the provided configuration parameters.
+ *
+ * @example
+ * ```ts


Suggested change

* ```ts

* ```ts twoslash

moldy530 · 2025-01-24T16:28:03Z

site/pages/reference/account-kit/infra/functions/alchemyGasManagerMiddleware.mdx

 import { http } from "viem";

 const client = createSmartAccountClient({
  transport: http("rpc-url"),
  chain: sepolia,
-  ...alchemyGasManagerMiddleware("policyId"),


oh I saw this in a another PR somewhere too... This looks like a bug in main 🤔

I think this is a git issue somewhere - it was fixed in a different PR that's already merged

* feat: adds initial impl of signAuthorization * docs: adds signAuthorization documentation * fix: rename var

…tions

adamegyed requested review from moldy530, rthomare, dancoombs, mokok123, dphilipson, linnall, howydev, Zer0dot, jaypaik, Blu-J, noam-alchemy and jakehobbs as code owners January 23, 2025 01:41

vercel bot deployed to Preview – aa-sdk-ui-demo January 23, 2025 01:43 View deployment

vercel bot deployed to Preview – aa-sdk-site January 23, 2025 01:49 View deployment

adamegyed changed the title ~~feat: EIP-7702 support in aa-sdk/core, and SMA7702 support in account-kit/smart-contracts~~ feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts Jan 23, 2025

vercel bot deployed to Preview – aa-sdk-ui-demo January 23, 2025 16:06 View deployment

vercel bot deployed to Preview – aa-sdk-site January 23, 2025 16:10 View deployment

adamegyed force-pushed the adam/7702-core branch from 6797694 to ed436d8 Compare January 23, 2025 16:56

vercel bot deployed to Preview – aa-sdk-ui-demo January 23, 2025 17:07 View deployment

vercel bot deployed to Preview – aa-sdk-site January 23, 2025 17:10 View deployment

vercel bot deployed to Preview – aa-sdk-ui-demo January 23, 2025 20:40 View deployment

vercel bot deployed to Preview – aa-sdk-site January 23, 2025 20:44 View deployment

moldy530 reviewed Jan 24, 2025

View reviewed changes

adamegyed mentioned this pull request Jan 24, 2025

feat: eip 7702 support and demo #1268

Closed

7 tasks

adamegyed requested a review from archit2407 as a code owner January 27, 2025 18:59

vercel bot deployed to Preview – aa-sdk-ui-demo January 27, 2025 19:16 View deployment

vercel bot deployed to Preview – aa-sdk-site January 27, 2025 19:16 View deployment

adamegyed force-pushed the adam/7702-core branch from c0d52b7 to 847ab00 Compare January 29, 2025 22:53

vercel bot deployed to Preview – aa-sdk-ui-demo January 29, 2025 23:06 View deployment

vercel bot deployed to Preview – aa-sdk-site January 29, 2025 23:09 View deployment

adamegyed and others added 13 commits January 30, 2025 13:53

feat: sma 7702

03a8666

feat: adds 7702 support to alchemy signer (#1269)

a84a897

* feat: adds initial impl of signAuthorization * docs: adds signAuthorization documentation * fix: rename var

feat: 7702 progress

654c08f

feat: update viem and debug 7702 auth

4939fe8

feat: add deterministically deployed demo nft

bbb1d2d

fix: don't re-sign delegations

5ed901f

feat: update 7702 middleware to higher order function

764e4fc

chore: merge fixes

4880d89

fix: remove unnecessary console log

e272112

fix: correctly await client actions in infra test

bc3994f

fix: correctly encode yParity in zero case

dd101aa

feat: correctly set validation entity in nonce and separate encode ac…

ddd6b04

…tions

feat: consolidate MAv2Base

7d20b9f

adamegyed force-pushed the adam/7702-core branch from 847ab00 to 7d20b9f Compare January 30, 2025 18:59

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo January 30, 2025 19:01 Failure

vercel bot deployed to Preview – aa-sdk-site January 30, 2025 19:13 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts #1287

feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts #1287

adamegyed commented Jan 23, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 23, 2025 •

edited

Loading

graphite-app bot commented Jan 23, 2025

moldy530 left a comment

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

adamegyed Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

moldy530 Jan 24, 2025

adamegyed Jan 24, 2025

		// TODO: this isn't the cleanest because now the account implementation HAS to know that it needs to return an impl address
		// even if the account is not deployed

feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts #1287

Are you sure you want to change the base?

feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts #1287

Conversation

adamegyed commented Jan 23, 2025 • edited by pr-codex bot Loading

Pull Request Checklist

PR-Codex overview

Detailed summary

vercel bot commented Jan 23, 2025 • edited Loading

graphite-app bot commented Jan 23, 2025

How to use the Graphite Merge Queue

moldy530 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamegyed commented Jan 23, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 23, 2025 •

edited

Loading