-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding delay after OTP code validation #1288
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6a8facd
feat: adding getSessionType
0242cc8
feat: adding some comments to new logic
858b2ec
feat: adding back the delay on otp side
6456b7e
feat: using useAuthContext to validate authenticated user and use otp…
4753756
Merge branch 'main' into caleb/otp-delay
85870f2
feat: removing un-necessary file
3205afd
feat: updating delay to 1 second
62bb975
Update account-kit/react/src/components/auth/context.ts
jcaleb4 a830e0b
Merge branch 'main' into caleb/otp-delay
jcaleb4 e77b059
Merge branch 'main' into caleb/otp-delay
RobChangCA 1cff615
Merge branch 'main' into caleb/otp-delay
RobChangCA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...pages/reference/account-kit/signer/classes/BaseAlchemySigner/getSessionType.mdx
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this file a bit... seems like a few things are at play potentially.
If calling
authenticate
with the OTP code is hitting bothonSuccess
andisConnected == true
then that should be a logged in user. If the user is not logged in, thenisConnected
shouldn't be true and should likely still be in an authenticating state (similar to how magic link used to be in anemail_authenticating
state). I imagine the signer would similarly be in anemail_awaiting_otp
state and onceauthenticate
returns successfully, it should update theSignerStatus
to completeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just tried it out on a local branch with the delay removed altogether and seems to work without issue, so this might actually just be me missing context. Is this is a it's "too fast" situation?