Fix: import multihash (caused by aioipfs) #673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a dependency conflict caused by two libraries, pymultihash and py-multihash, both of which provide a module named multihash. The conflict arises because:
pymultihash is required by pyaleph and is imported as multihash.
py-multihash is now required by aioipfs.
Self proofreading checklist
Changes
This pull request includes updates to the
src/aleph/toolkit/libp2p_stubs/peer/id.py
file to improve compatibility with themultihash
library. The changes mainly involve updating import statements and method calls to reflect the latest structure of themultihash
library.Updates to
multihash
library usage:multihash.funcs
for better organization and clarity.multihash.FuncReg.register
tomultihash.funcs.FuncReg.register
in theupdate
method to align with the new library structure.from_pubkey
method to usemultihash.funcs.Func.sha2_256
andmultihash.Multihash.digest
to ensure compatibility with the updatedmultihash
library.How to test
You can try to sync you'r CCN