Support booleans in the cli #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-b
force-pushed
the
support-bool
branch
from
bd4dcb6 to
23fef1a
Compare
anton-b
force-pushed
the
support-bool
branch
from
23fef1a to
ce9868f
Compare
|
@ptrakhtman any objection to such approach? The only thing is that it will be always passing booleans even if not specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Boolean types are not supported in the alcli
Resolution
alcli --bool_type
evaluate to bool_type == True
absence of the --bool_type, evaluates to False when passed in the service call