Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-52244]Upgrade collectors aws-sdk version from v2 to v3 and rewrite functionality and test cases #354

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

rakhimundhada15
Copy link
Contributor

Problem Description

Lambda Runtime nodejs 18 used aws-sdk v3 version

Solution Description

  • Upgrade collectors from aws-sdk version from v2 to v3
  • update the functionality as per v3 version
  • Fix the test cases.
  • Removed aws-sdk and aws-sdk-mock both dependancy.

@al-cibot
Copy link

al-cibot commented Nov 3, 2023

CI Service Job Number 893 Logs - FAILURE

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 893 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

al-cibot commented Nov 3, 2023

CI Service Job Number 894 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 894 -g

Stages Run:

  • PR Test

Copy link
Contributor

@scott-jones-AlertLogic scott-jones-AlertLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks Rakhi!

@al-cibot
Copy link

al-cibot commented Nov 3, 2023

CI Service Job Number 895 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 895 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

al-cibot commented Nov 6, 2023

CI Service Job Number 896 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 896 -g

Stages Run:

  • PR Test

@rakhimundhada15 rakhimundhada15 merged commit 54b903c into alertlogic:master Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants