Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-53369 : GCP collector - Handle the pagination state properly #357

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

rakhimundhada15
Copy link
Contributor

Problem Description

Collector losses the data as state since and until value not set properly during pagination scenario.
Example : If there is lots of pages and collector collected paws_max_pages_per_invocation(default -10) max pages in one call , if there is still nextPage token since and until value should not change but currently it changes after every call . So if there is no more page it will start collecting the until value which is latest. Hence it lost the data for some period

Solution Description

If nextPage available then don’t change since & until value only update next_token else update the since and until pass in next filter.

@al-cibot
Copy link

CI Service Job Number 903 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 903 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

CI Service Job Number 904 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 904 -g

Stages Run:

  • PR Test

@rakhimundhada15 rakhimundhada15 merged commit d6ce837 into alertlogic:master Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants