ENG-53369 : GCP collector - Handle the pagination state properly #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Collector losses the data as state since and until value not set properly during pagination scenario.
Example : If there is lots of pages and collector collected paws_max_pages_per_invocation(default -10) max pages in one call , if there is still nextPage token since and until value should not change but currently it changes after every call . So if there is no more page it will start collecting the until value which is latest. Hence it lost the data for some period
Solution Description
If nextPage available then don’t change since & until value only update next_token else update the since and until pass in next filter.