Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAWS][ENG-55567] Replace GCP collector npm library google-cloud-logging to googleapis to convert protopayload to json #372

Merged

Conversation

imranalisyed506
Copy link
Contributor

@imranalisyed506 imranalisyed506 commented Jul 1, 2024

Problem Description

[GoogleStackDriver] Buffer portion of GCP log not being decoded for AuditLog type

Solution Description

Currently the npm package we use @google-cloud/logging for the GCP collector is returning protobuf for protoPayload which we then have to convert into json but json converted is verlong with type value for example(strinValue,numberValue and lots of uneccessary fields). this PR contains logic #365
but there is a npm package library that does this natively googleapis. We need to switch to use this library and thus remove the decoding that was added to convert to json.

…ing to googleapis to convert protopayload to json
@al-cibot
Copy link

al-cibot commented Jul 1, 2024

CI Service Job Number 1009 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1009 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

al-cibot commented Jul 3, 2024

CI Service Job Number 1015 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1015 -g

Stages Run:

  • PR Test

Copy link
Contributor

@rakhimundhada15 rakhimundhada15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only some indentation related comments.

@al-cibot
Copy link

al-cibot commented Jul 3, 2024

CI Service Job Number 1016 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1016 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

al-cibot commented Jul 3, 2024

CI Service Job Number 1017 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1017 -g

Stages Run:

  • PR Test

@imranalisyed506 imranalisyed506 force-pushed the im-gsuiteapijun27changes branch from 5357a6f to 0a8353c Compare July 3, 2024 07:22
@al-cibot
Copy link

al-cibot commented Jul 3, 2024

CI Service Job Number 1018 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1018 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

al-cibot commented Jul 3, 2024

CI Service Job Number 1020 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1020 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

al-cibot commented Jul 5, 2024

CI Service Job Number 1026 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1026 -g

Stages Run:

  • PR Test

…ing to googleapis to convert protopayload to json
@al-cibot
Copy link

al-cibot commented Jul 5, 2024

CI Service Job Number 1027 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1027 -g

Stages Run:

  • PR Test

@imranalisyed506
Copy link
Contributor Author

build-collector-googlestackdriver

@al-cibot
Copy link

al-cibot commented Jul 5, 2024

CI Service Job Number 1028 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1028 -g

Stages Run:

  • build-collector-googlestackdriver
  • file_packager_6f0923

@imranalisyed506 imranalisyed506 deleted the im-gsuiteapijun27changes branch July 25, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants