-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradians, degrees/minutes/seconds support. #4
Open
alexbarry
wants to merge
15
commits into
main
Choose a base branch
from
gradians_degrees
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: now the HTML UI button indicates the current angle mode state, rather than the state that you will be brought to if you press it. TODO: add a warning to the UIs about this.
This prevents sin(2*pi) or sin(180 degrees) from returning 1e-16 something. I am probably missing some more of these with complex math, but this is a good start.
I still need to add the LaTeX handling of this
This way you can print the type of a node when debugging.
This way, instead of seeing "\text{123}" in the LaTeX, you'll see only "123". The main motivation for this was adding degrees, since those are numeric-ish and wouldn't render inside a "\text{}".
Otherwise the process seems to remain running, potentially consuming a bunch of ram if you mess up the regexes and get stuck in an infinite loop...
Including fixing a really bad bug where the "within difference" function wasn't taking the absolute value, causing a bunch of clearly wrong tests to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor: