Skip to content

fix overflow in parameter sizes for ARP timeouts #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix overflow in parameter sizes for ARP timeouts #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rtl/arp.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ module arp #
// ARP request retry count
parameter REQUEST_RETRY_COUNT = 4,
// ARP request retry interval (in cycles)
parameter REQUEST_RETRY_INTERVAL = 125000000*2,
parameter [35:0] REQUEST_RETRY_INTERVAL = 36'd125000000*2,
// ARP request timeout (in cycles)
parameter REQUEST_TIMEOUT = 125000000*30
parameter [35:0] REQUEST_TIMEOUT = 36'd125000000*30
)
(
input wire clk,
Expand Down
4 changes: 2 additions & 2 deletions rtl/ip_complete.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ THE SOFTWARE.
module ip_complete #(
parameter ARP_CACHE_ADDR_WIDTH = 9,
parameter ARP_REQUEST_RETRY_COUNT = 4,
parameter ARP_REQUEST_RETRY_INTERVAL = 125000000*2,
parameter ARP_REQUEST_TIMEOUT = 125000000*30
parameter [35:0] ARP_REQUEST_RETRY_INTERVAL = 36'd125000000*2,
parameter [35:0] ARP_REQUEST_TIMEOUT = 36'd125000000*30
)
(
input wire clk,
Expand Down
4 changes: 2 additions & 2 deletions rtl/ip_complete_64.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ THE SOFTWARE.
module ip_complete_64 #(
parameter ARP_CACHE_ADDR_WIDTH = 9,
parameter ARP_REQUEST_RETRY_COUNT = 4,
parameter ARP_REQUEST_RETRY_INTERVAL = 156250000*2,
parameter ARP_REQUEST_TIMEOUT = 156250000*30
parameter [35:0] ARP_REQUEST_RETRY_INTERVAL = 36'd156250000*2,
parameter [35:0] ARP_REQUEST_TIMEOUT = 36'd156250000*30
)
(
input wire clk,
Expand Down
4 changes: 2 additions & 2 deletions rtl/udp_complete.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ THE SOFTWARE.
module udp_complete #(
parameter ARP_CACHE_ADDR_WIDTH = 9,
parameter ARP_REQUEST_RETRY_COUNT = 4,
parameter ARP_REQUEST_RETRY_INTERVAL = 125000000*2,
parameter ARP_REQUEST_TIMEOUT = 125000000*30,
parameter [35:0] ARP_REQUEST_RETRY_INTERVAL = 36'd125000000*2,
parameter [35:0] ARP_REQUEST_TIMEOUT = 36'd125000000*30,
parameter UDP_CHECKSUM_GEN_ENABLE = 1,
parameter UDP_CHECKSUM_PAYLOAD_FIFO_DEPTH = 2048,
parameter UDP_CHECKSUM_HEADER_FIFO_DEPTH = 8
Expand Down
4 changes: 2 additions & 2 deletions rtl/udp_complete_64.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ THE SOFTWARE.
module udp_complete_64 #(
parameter ARP_CACHE_ADDR_WIDTH = 9,
parameter ARP_REQUEST_RETRY_COUNT = 4,
parameter ARP_REQUEST_RETRY_INTERVAL = 125000000*2,
parameter ARP_REQUEST_TIMEOUT = 125000000*30,
parameter [35:0] ARP_REQUEST_RETRY_INTERVAL = 36'd125000000*2,
parameter [35:0] ARP_REQUEST_TIMEOUT = 36'd125000000*30,
parameter UDP_CHECKSUM_GEN_ENABLE = 1,
parameter UDP_CHECKSUM_PAYLOAD_FIFO_DEPTH = 2048,
parameter UDP_CHECKSUM_HEADER_FIFO_DEPTH = 8
Expand Down