Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable implementation of crc32_hw #696

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

lihuiba
Copy link
Collaborator

@lihuiba lihuiba commented Jan 9, 2025

Translated from the assembly implementation of ISA-L.

Its performance compared to the asm implementations is:

ARM X86_64
small data block 28% faster similar
big data block 2.2x faster similar

The portable implementation is smaller in machine code size than the assembly implementation (6,335 bytes vs 10,542 bytes), using gcc 9.2.1.

@lihuiba lihuiba requested review from beef9999 and Coldwings January 9, 2025 10:18
@lihuiba lihuiba force-pushed the crc32_hw_portable branch 4 times, most recently from 9cdd1a1 to 518abd1 Compare January 10, 2025 06:38
Copy link
Collaborator

@Coldwings Coldwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lihuiba lihuiba merged commit f34745b into alibaba:main Jan 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants