Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Getting MatchLabels dynamically via gatewaySelectorKey/Value #1857 #1883

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

waTErMo0n
Copy link

Ⅰ. Describe what this PR did

Getting MatchLabels dynamically via gatewaySelectorKey/Value

Ⅱ. Does this pull request fix one issue?

feat #1857

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

1.我是一个新手,不太确定代码否正确,感谢这次机会
2.作为一个新手,让我准备好higress开发环境所需要的文档太过分散且难以寻找,希望针对开发环境的准备能有更完备的文档和点击入口

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.75%. Comparing base (ef31e09) to head (40accab).
Report is 358 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/config/ingress_config.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
+ Coverage   35.91%   43.75%   +7.83%     
==========================================
  Files          69       78       +9     
  Lines       11576    12480     +904     
==========================================
+ Hits         4157     5460    +1303     
+ Misses       7104     6678     -426     
- Partials      315      342      +27     
Files with missing lines Coverage Δ
pkg/ingress/config/ingress_config.go 13.25% <50.00%> (-0.62%) ⬇️

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CH3CHO
Copy link
Collaborator

CH3CHO commented Mar 18, 2025

LGTM. But please fix the conflict.

@waTErMo0n
Copy link
Author

LGTM. But please fix the conflict.

done

@CH3CHO
Copy link
Collaborator

CH3CHO commented Mar 18, 2025

Since this is related to the core function of the controller, @johnlanni PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants